container: fix legacy docker_volumes compatibility, add missing arguments to argument specs

roles/container/tasks/volumes.yml

@@ -2,8 +2,8 @@
 
 - name: Create directories and put files in them
   when:
-    - docker_volumes | length > 0
-    - (docker_volume_type == 'bind') or (docker_volumes | selectattr('template', 'defined') | list | length > 0)
+    - docker_mounts | length > 0
+    - (docker_volume_type == 'bind' and docker_mounts | selectattr('name', 'defined') | list | length > 0) or (docker_mounts | selectattr('template', 'defined') | list | length > 0)
   block:
     - name: Create directory /opt/{{ docker_service + '/' + docker_service_suffix }}
       file:
@@ -42,33 +42,33 @@
         owner: "{{ mount_owner if (item.set_owner is not defined or item.set_owner) and mount_owner | length > 0 else omit }}"
         group: "{{ mount_group if (item.set_group is not defined or item.set_group) and mount_group | length > 0 else omit }}"
       when: item.name is defined
-      loop: "{{ docker_volumes }}"
+      loop: "{{ docker_mounts }}"
     - name: Set docker_volume_definition for named binds
       set_fact:
         docker_volume_definition: "{{ docker_volume_definition + [{'source': docker_mounts_dir + '/' + item.name, 'target': item.path, 'type': 'bind'}] }}"
       when: item.name is defined
-      loop: "{{ docker_volumes }}"
+      loop: "{{ docker_mounts }}"
 
     - name: Template docker template mounts for {{ docker_service_name }}
       template:
         src: "{{ item.template }}.j2"
         dest: "{{ docker_mounts_dir }}/{{ item.template }}"
       when: item.template is defined
-      loop: "{{ docker_volumes }}"
+      loop: "{{ docker_mounts }}"
     - name: Set docker_volume_definition for template mounts
       set_fact:
         docker_volume_definition: "{{ docker_volume_definition + [{'source': docker_mounts_dir + '/' + item.template, 'target': item.path, 'type': 'bind', 'read_only': true}] }}"
       when: item.template is defined
-      loop: "{{ docker_volumes }}"
+      loop: "{{ docker_mounts }}"
 
 - name: Set docker_volume_definition for named volumes
   set_fact:
     docker_volume_definition: "{{ docker_volume_definition + [{'source': docker_service_name + '_' + item.name, 'target': item.path, 'type': 'volume'}] }}"
   when: docker_volume_type == 'named' and item.name is defined
-  loop: "{{ final_docker_volumes }}"
+  loop: "{{ docker_mounts }}"
 
 - name: Set docker_volume_definition for src binds
   set_fact:
     docker_volume_definition: "{{ docker_volume_definition + [{'source': item.src, 'target': item.path, 'type': 'bind'}] }}"
   when: item.src is defined
-  loop: "{{ final_docker_volumes }}"
+  loop: "{{ docker_mounts }}"